roryashfordbentley / Wordpress-Bem-Menu

Better menu implementation for Wordpress using BEM syntax
139 stars 23 forks source link

Mark parent navigation active when on custom post type single page #15

Open mdominguez opened 8 years ago

mdominguez commented 8 years ago

First of all, thank you for your effort in this piece of code! :) Problem: when you visit a custom post type's single page, the parent menu item (the post type archive) isn't marked as active.

Thanks in advance for resolving this!

roryashfordbentley commented 8 years ago

Hey @mdominguez I'm on vacation at the moment but I will take a look into this as soon as I can. If you manage to fix it yourself feel free to submit a pull request which I will test and merge :)

runnickrun commented 7 years ago

Hello and thanks for the great code! Any update on this?

For regular WP menu this solution seems to work: https://gist.github.com/gerbenvandijk/5253921#gistcomment-1281838

roryashfordbentley commented 7 years ago

Hey @runnickrun , thanks for the kind words. I will check out the Gist you posted and see what we can do. Im really swamped with work at the moment so feel free to submit a PR if you get it working and I'll happily merge it.

runnickrun commented 7 years ago

Thanks, I understand if you're busy so no problem. I just don't think I have enough knowledge for accomplishing it.