funtioncall matches too aggressive, break Ctrl+R/definition list

[Xuerian]

Not sure if it is intended, but Ctrl+R becomes completely unusable for locating function definitions with this broad of a rule.

Commenting functioncall... from LuaDev\Lua.tmLanguage resolves this. Edit: Alternately, commenting the beginCaptures section of the above retains meta.functioncall* highlighting but doesn't clutter console-@ list. Admittedly, I'm not entirely sure how the .tmLanguage system works.

Also, I'm not sure if it's a conflict between the default Lua package and yours, but function table:Method() is not matched, where function Method() and function table.Method()

[rorydriscoll]

It looks like Sublime Text automatically adds all entity.name.function scopes to the symbol list. I had been tagging the names of functions inside function calls with this, so I've removed it. I also removed the variable tagging, since that seems (looking at python) to be reserved for function parameters.

I've also changed the function declaration expression to allow table:Method()

[Xuerian]

Variable tagging was actually pretty nice. I wonder, what about using custom tags/names for it, so it can still be highlighted but isn't parsed into the wrong lists?

I appreciate the fix, either way.

[rorydriscoll]

I can replace the variable highlighting if you would prefer it. I don't mind either way to be honest.

On Mon, Nov 12, 2012 at 1:13 PM, Xuerian notifications@github.com wrote:

Variable tagging was actually pretty nice. I wonder, what about using custom tags/names for it, so it can still be highlighted but isn't parsed into the wrong lists?

I appreciate the fix, either way.

— Reply to this email directly or view it on GitHubhttps://github.com/rorydriscoll/LuaSublime/issues/5#issuecomment-10304539.

[Xuerian]

I wasn't a fan until I used it for a bit, but it provided some helpful contrast. I didn't notice it breaking any functionality similar to the symbols list, either, so it could be nice to have.

At least until someone else comes along and explains what it breaks.

Edit: Is there a good reference for these format files somewhere? It would be helpful to be able to hack on them and make a more tested suggestion, but a cursor search didn't find anything conclusive - I'm sure I just missed it.

[rorydriscoll]

Ok, the variable coloring is back. I think this fixes your issues.

[Xuerian]

Looks great. Thanks =)