search

roryeiffe / Spoiler-Block

Google Chrome Extension that filters out search result suggestions that "spoil" or reveal plot elements of the media (shows, movies, books, etc.).
GNU General Public License v3.0
0 stars 3 forks source link

Saving Color and Threshold Null Values #56

Closed SerenaChen1 closed 3 years ago

SerenaChen1 commented 3 years ago

Currently on the AppState branch, I have it so that we don't save the color and threshold if they are both null. However, this means that when we just open the extension popup without selecting a color (the color is null but threshold is not because threshold always has a default value), we null for color. And when we refresh the webpage, the censor doesn't show up because the color is null.

SerenaChen1 commented 3 years ago

I fixed this simply by separately checking each value to make sure they weren't null before saving them.