search

roryg / ElementHelper

Element Helper is a MODx Revolution plugin for automatically creating elements from static files without the MODx manager.
27 stars 10 forks source link

Not working for MODX Revolution 2.3 #26

Open DESIGNfromWITHIN opened 10 years ago

DESIGNfromWITHIN commented 10 years ago

Am I right that ElementHelper is not working on MODX Revolution 2.3? Would love to use it on my experimental installs!

roryg commented 10 years ago

Hmm, probably not if big changes have been made to the way elements are handled in 2.3. I've only tested on the current stable version of Revolution so far but it looks like they're getting close to releasing 2.3 so I'll have to do something about that.

mjpugh commented 10 years ago

I also just tried to use ElementHelper in the latest nightly release of MODX Revo 2.3, and it does not appear to be working. It would be really great to have ElementHelper ready for the Revo 2.3 public release. Do you have a new release of ElementHelper in the works?

roryg commented 10 years ago

I've just seen Modx 2.3 is scheduled for release on the 15th so I'm going to try and have a new better version ready before then. :)

Mark-H commented 10 years ago

What is actually broken in 2.3?

Mark-H commented 10 years ago

Figured I'd go through the source to see if I could spot anything that might be broken for 2.3.

https://github.com/roryg/ElementHelper/blob/master/core/components/elementhelper/elements/plugins/plugin.elementhelper.php#L10 and https://github.com/roryg/ElementHelper/blob/master/core/components/elementhelper/elements/plugins/plugin.elementhelper.php#L297 $modx->getMicroTime() has been deprecated for a long time and should not have been used. It was removed in 2.3. Use microtime(true) instead.

That's the only thing that stood out for me in the source.

sonicpunk commented 9 years ago

Is this going to get updated for use in 2.3?

roryg commented 9 years ago

@sonicpunk I'm working on a new version that you can download here https://github.com/roryg/ElementHelper/issues/31

Unfortunately things keep coming up that prevent me from finishing it so I can't say when it will be completely done. :smile: