roryg / ghostwriter

A simple AJAX driven Ghost theme.
MIT License
869 stars 360 forks source link

1.0 compatibility #99

Closed gllmhyt closed 7 years ago

gllmhyt commented 7 years ago

There's a few changes in the upcoming 1.0 release that we need to fix. According to gscan:

Must fix

Replace the {{image}} helper with {{feature_image}}, {{cover_image}} or {{profile_image}}.

  • author.hbs: Please remove or replace {{image}} from this template
  • page.hbs: Please remove or replace {{image}} from this template
  • partials/post-content.hbs: Please remove or replace {{image}} from this template

Replace the {{#if image}} helper with {{#if feature_image}}, or {{#if cover_image}}, or {{#if profile_image}}.

  • author.hbs: Please remove or replace {{#if image}} from this template
  • page.hbs: Please remove or replace {{#if image}} from this template
  • partials/post-content.hbs: Please remove or replace {{#if image}} from this template

Usage of {{meta_description}} in HTML head is deprecated.

  • default.hbs: Please remove or replace {{meta_description}} from this template

package.json author.email is required.

package.json author.email must be valid.

package.json name must be lowercase.

Consider fixing

package.json config.page_per_post is recommended. Otherwise, it falls back to 5.

roryg commented 7 years ago

Thanks @postblue I'll take a look at this soon

gllmhyt commented 7 years ago

You're welcome! As Ghost 0.11.11 adds forward compatibility for Ghost 1.0 themes, I'll give it a shot soon to.

roryg commented 7 years ago

All changes have been made so Ghostwriter will now be ready for Ghost 1.0 🙂

gllmhyt commented 7 years ago

Yay, thx!