search

roryk / ipython-cluster-helper

Tool to easily start up an IPython cluster on different schedulers.
148 stars 23 forks source link

fix to allow clean build on python3.4 #24

Closed mjdellwo closed 9 years ago

mjdellwo commented 9 years ago

these changes allow for clean install on python3.4, and still works on python2.7 as well.

roryk commented 9 years ago

Hi @mjdellwo,

Thanks a lot for the fixes, I suck at writing python 3 compatible code. It would be sweet to have this working on 3 as well, so please let us know if you run into anything else that isn't compatible.

mjdellwo commented 9 years ago

No problem, I'm no Python3 expert but that was an easy fix.

By the way, I'm a newbie to git and github, was it the right think to fork your repo or could I have created a bug-fix branch right off your repo? I couldn't see how to do the latter, but don't really intend to maintain a separate fork! ;) -Marty

roryk commented 9 years ago

Hi @mjdellwo,

You did the right thing, forking and issuing a pull request is right on. Your changes are merged in now so you don't have to keep your fork around if you don't want to. If you're new to git, there's a great book that you can look at for free about git that I think does an awesome job explaining how it works and makes it easier to wrap your head around it: http://git-scm.com/book/en/v2

Thanks a lot for contributing!