search

roryk / ipython-cluster-helper

Tool to easily start up an IPython cluster on different schedulers.
148 stars 23 forks source link

Python 3 support for Slurm helper #55

Closed vladsavelyev closed 7 years ago

vladsavelyev commented 7 years ago

Added python 3 support for Slurm. SGE works fine with python 3 already.

By the way, what do you think about dropping the ipyparallel <5.0 requirement in conda? This will allow to add python 3.6 support. I can't see any breaking changes introduced: https://ipyparallel.readthedocs.io/en/latest/changelog.html#id3, and it works fine for me (I'm using and altered conda package version https://github.com/vladsaveliev/NGS_Utils/blob/master/conda/ipython-cluster-helper/meta.yaml). However I agree that this might be dangerous and probably not a best idea at all. Just something to consider.

roryk commented 7 years ago

Thanks! This looks great. I agree about the unpinning the top end of the ipython requirement as well.

roryk commented 7 years ago

Can you add yourself to the contributor list at the bottom? Thanks! :)