Nullsafety v2 - Githubissues

rorystephenson / flutter_map_marker_popup

Popups for flutter_map markers

BSD 3-Clause "New" or "Revised" License

103 stars 84 forks source link

Nullsafety v2 #21

Closed rorystephenson closed 3 years ago

rorystephenson commented 3 years ago

This includes null safety support as well as some big upgrades:

Handle rotation.
Many bug fixes
An example app that lets you dynamically change all of the options to try it out
Update to the latest version of flutter_map.
Many others... I will try to sum it up better when I create a release and add to the CHANGELOG.md.

bmason8 commented 3 years ago

Is there any plan to replace the 'latlong' package with one of the newer latlong packages like 'latlong2? I'm having an issue (that I suspect others might have) where 'latlong: 0.6.1' depends on logging >=0.11.3 <1.0.0 but build_runner >=2.0.0 depends on logging ^1.0.0. Thanks, I appreciate the work on this package and look forward to the updates in this PR.

rorystephenson commented 3 years ago

Good point! Actually I can remove the latlong dependency from this package since it's not using it directly anymore. I will do that when I get a chance (not at my computer right now).

rorystephenson commented 3 years ago

@bmason8 that's pushed now :).

bmason8 commented 3 years ago

@bmason8 that's pushed now :).

Thank you!

sbu-WBT commented 3 years ago

flutter_map: ^0.13.0 is released with null safety so this can get merged

rorystephenson commented 3 years ago

flutter_map: ^0.13.0 is released with null safety so this can get merged

I saw that it has been released 🥳 ! Howeeeever there is a major bug that causes the example app (and probably any app) to crash as soon as you move the map: https://github.com/fleaflet/flutter_map/pull/923 .

danielocampo2 commented 3 years ago

@rorystephenson flutter_map: ^0.13.1 has been released with the fix

rorystephenson commented 3 years ago

@rorystephenson flutter_map: ^0.13.1 has been released with the fix

Did you notice the last two commits?