search

rorystephenson / flutter_map_marker_popup

Popups for flutter_map markers
BSD 3-Clause "New" or "Revised" License
103 stars 84 forks source link

Update latlong2 to 0.9.0 #62

Closed flodaniel closed 1 year ago

flodaniel commented 1 year ago

LatLong2 published new major version, which this package should support: https://pub.dev/packages/latlong2/changelog

rorystephenson commented 1 year ago

I'm working on a large set of changes to make #61 possible, amongst other things. I will first release that with the same latlong2 version and shortly after will work on migrating to dart 3 which latlong2 0.9.0 requires.

flodaniel commented 1 year ago

Cool! Thank you for your effort! 🚀

rorystephenson commented 1 year ago

So releasing a dart 3 compatible version can be done but flutter_map needs to publish a version with latlong2 0.9.0 before I can bump latlong2 in this package. There is a version 5 prelease but I will wait for a proper release.

niku commented 1 year ago

Hi, flutter_map v5.0 was released yesterday. So, it seems you don't have to keep latlong2 0.8 any longer 👋

rorystephenson commented 1 year ago

Thanks for the heads-up. I've posted a comment on the 5.0 PR about one change which affects this plugin, once we have determined whether a further change occurs or not I will release a new version.

Felipe-N0bre commented 1 year ago

https://github.com/fleaflet/flutter_map/pull/1532#pullrequestreview-1466723876 has been merged, any prevision when we can have this update? Thanks!

rorystephenson commented 1 year ago

@Felipe-N0bre that PR is where I commented on the change, the issue discussing a fix is here: https://github.com/fleaflet/flutter_map/issues/1552

elliotnash commented 1 year ago

I see that the merged fix is targeting flutter map v6 - will we have a version of marker popup for v5 (even if performance is worse) or do we need to wait until flutter map v6 is released?

rorystephenson commented 1 year ago

I see that the merged fix is targeting flutter map v6 - will we have a version of marker popup for v5 (even if performance is worse) or do we need to wait until flutter map v6 is released?

Hi @elliotnash , I will try to get time in the next couple of days to release a version for v5.

rorystephenson commented 1 year ago

Thanks for the patience everyone, 5.2.0 is now released which supports flutter_map v5 and latlong2 0.9.0.