rorywalsh / CsoundUnity

GNU Lesser General Public License v2.1
72 stars 20 forks source link

LinkButton reference with latest package #34

Closed nathanjams closed 2 years ago

nathanjams commented 2 years ago

Hello,

Just tried installing the latest (3.3.0) in Unity 2020.3.32 on Windows 10 and I get this error: Library\PackageCache\com.csound.csoundunity@058320a7cf\Editor\CsoundUnityEditor.cs(403,27): error CS0117: 'EditorGUI' does not contain a definition for 'LinkButton'

Thank you for this package, I can not wait to get started with it. Nathan

giovannibedetti commented 2 years ago

Yes, sorry for that, I haven't tested the latest release on older Unity versions. I will add a check for older versions and will draft a new release asap. The LinkButton has been added in Unity 2021, so while waiting for the new release you will need to use a Unity version above that to be able to use the package. Otherwise use CsoundUnity version 3.2.1

giovannibedetti commented 2 years ago

Fix available in this branch: fix-linkbutton use this package git url to test it: https://github.com/rorywalsh/CsoundUnity.git#fix-linkbutton

nathanjams commented 2 years ago

Hello,

Just upgraded my project to 2021.1.28 and can confirm that the existing package worked with this version of Unity. Thanks for getting back to me so quickly.

Haven't used CSound since I was in university a long time ago. Extremely excited to start a Unity project with it! Thank you so much for making this possible ;)

giovannibedetti commented 2 years ago

version 3.3.1 fixed this issue: https://github.com/rorywalsh/CsoundUnity/releases/tag/v3.3.1 you can now use again the master branch on Unity versions older than 2021.1.

Feel free to post your progress or questions on https://forum.cabbageaudio.com/ or https://forum.csound.com/, I'm very curious to see what people can create with this package!

closing the issue!

giovannibedetti commented 2 years ago

@all-contributors add @nathanjams for bug

allcontributors[bot] commented 2 years ago

@giovannibedetti

I've put up a pull request to add @nathanjams! :tada: