rorywalsh / CsoundUnity

GNU Lesser General Public License v2.1
72 stars 20 forks source link

Drag&Drop stops working in Unity Editor on Windows #42

Closed giovannibedetti closed 1 year ago

giovannibedetti commented 1 year ago

After playing a scene with a CsoundUnity instance, drag&drop in the Unity Editor stops working. Restarting the Editor fixes it. Not reproduced on MacOS (any version). Reproduced with all Unity versions on Windows with Csound v6.18 and v6.17

giovannibedetti commented 1 year ago

It is probably caused by FLTK opcodes, that are present in the Windows version of Csound 6.17. EDIT: The same behaviour is happening with Csound 6.18.

To (possibly) fix the drag&drop issue, rebuild csound64.dll without the FLTK opcodes.

EDIT: Removing Csound and Csound plugins from the PATH doesn't help

rorywalsh commented 1 year ago

Fixed

ceberman commented 1 year ago

Hi, Giovanni, I just noticed the comment about FLTK opcodes, and just checking (and hoping that) the other sound font opcodes will continue to be supported (sfload, sfinstr) in future versions.

PS: Thanks again for all the ongoing work on this

On Oct 26, 2022, at 4:55 PM, Giovanni Bedetti @.***> wrote:

It is probably caused by FLTK opcodes, that are present in the Windows version of Csound 6.17. FLTK opcodes will be removed from the Csound version used in CsoundUnity v3.4.0

— Reply to this email directly, view it on GitHub https://github.com/rorywalsh/CsoundUnity/issues/42#issuecomment-1292642037, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH526DXPGSENPHWR6VRCQQLWFGLDNANCNFSM6AAAAAARGMVR4I. You are receiving this because you are subscribed to this thread.

giovannibedetti commented 1 year ago

Hi Charles, the issue was related with how we were handling the destruction of Csound. It wasn't related with FLTK opcodes. Just changing the order of operations fixed the issue. So no need to remove any opcode and rebuild Csound. The csound64.dll will be the one that comes with each Csound release. The fix will come in a patch release (3.4.1) soon

giovannibedetti commented 1 year ago

@all-contributors add @giovannibedetti for bug

allcontributors[bot] commented 1 year ago

@giovannibedetti

I've put up a pull request to add @giovannibedetti! :tada: