rorywalsh / cabbage

Framework for developing audio plugins with the Csound programming language.
http://cabbageaudio.com
GNU General Public License v3.0
503 stars 35 forks source link

Please add JUCE_WEB_BROWSER=0 to CLIConverter target #135

Closed KottV closed 1 year ago

KottV commented 1 year ago

Hi,

Currently CLIConverter wants webkit2gtk for building on Linux, which shouldn't be needed.

 if ("${PROJECT_NAME}" STREQUAL "CLIConverter")
     target_compile_definitions(${PROJECT_NAME}
         PRIVATE
             JUCE_WEB_BROWSER=0
             CLIConverter=1
rorywalsh commented 1 year ago

Thanks for this. I'll fix this later today.

On Wed 7 Sep 2022, 12:09 a.m. Konstantin Voinov, @.***> wrote:

Hi,

Currently CLIConverter wants webkit2gtk for building on Linux, which is shouldn't be needed.

if ("${PROJECT_NAME}" STREQUAL "CLIConverter") target_compile_definitions(${PROJECT_NAME} PRIVATE JUCE_WEB_BROWSER=0 CLIConverter=1

— Reply to this email directly, view it on GitHub https://github.com/rorywalsh/cabbage/issues/135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUQWGPJ5SSF4EJ4NOZKGMLV47FJLANCNFSM6AAAAAAQGIF64Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

KottV commented 1 year ago

tanks!