search

rorywalsh / cabbage

Framework for developing audio plugins with the Csound programming language.
http://cabbageaudio.com
GNU General Public License v3.0
509 stars 35 forks source link

Use angle brackets for JuceHeader.h includes instead of quoted relative paths #70

Closed andy-fillebrown closed 4 years ago

andy-fillebrown commented 4 years ago

This is a small step toward making Cabbage easier to build.

Projucer generally assumes there will be only one .jucer file used in a project. Multiple .jucer files are not well supported. To work around this limitation I would like to move each .jucer file to its own directory. Doing this will break the current JuceHeader.h includes because they use quotes instead of brackets and they use explicit paths relative to the files in the Source directory instead of relying on the project header search paths.

This change removes the explicit relative paths from the JuceHeader.h includes and changes the quotes to brackets so the project header search path is given priority. This will make it easier to merge later changes when the .jucer file moves are done.

rorywalsh commented 4 years ago

This will break all my CI scripts. I think rather than trying to find a better way of doing this with the Projucer, it might perhaps be best to look at using cmake? Cmake support was recently added to JUCE. The Projucer can be a real pain.

On Sat 8 Aug 2020, 11:24 Andy, notifications@github.com wrote:

This is a small step toward making Cabbage easier to build.

Projucer generally assumes there will be only one .jucer file used in a project. Multiple .jucer files are not well supported. To work around this limitation I would like to move each .jucer file to its own directory. Doing this will break the current JuceHeader.h includes because they use quotes instead of brackets and they use explicit paths relative to the files in the Source directory instead of relying on the project header search paths.

This change removes the explicit relative paths from the JuceHeader.h includes and changes the quotes to brackets so the project header search path is given priority. This will make it easier to merge later changes when the .jucer file moves are done.

You can view, comment on, or merge this pull request online at:

https://github.com/rorywalsh/cabbage/pull/70 Commit Summary

  • Remove relative directory prefixes when including JuceHeader.h
  • Use angle brackets when including JuceHeader.h

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rorywalsh/cabbage/pull/70, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUQWGJZPKMHBBNHQLAHXRTR7URUJANCNFSM4PYS3YZQ .

andy-fillebrown commented 4 years ago

Ok, but can you accept this PR anyway since all it does is change how JuceHeader.h is included? Moving forward I'll work on using CMake instead of Projucer, but even with CMake it will still be helpful to have JuceHeader.h included using angle brackets instead of quoted relative paths.

andy-fillebrown commented 4 years ago

Well, maybe hold off anyway... I just downloaded and installed the Windows package created on the Azure build server for this PR and the first plugin synth I tried crashed Reaper.

andy-fillebrown commented 4 years ago

I see support for CMake in Juce 6, but not Juce 5, and I have not been able to get Cabbage working with Juce 6. I hacked together a Juce 6 build with Projucer, but the Cabbage IDE stopped showing the cursor caret and plugins made with it had issues. I'll try again using CMake.

andy-fillebrown commented 4 years ago

Well, maybe hold off anyway... I just downloaded and installed the Windows package created on the Azure build server for this PR and the first plugin synth I tried crashed Reaper.

...but it's working fine now. Weird.

Regardless, I'm closing this PR. It will be easy enough to reproduce when it's needed.

rorywalsh commented 4 years ago

There is a cmake package out there for JUCE 5, https://github.com/McMartin/FRUT I've used it before, it was quite good.

On Sun 9 Aug 2020, 00:09 Andy, notifications@github.com wrote:

Well, maybe hold off anyway... I just downloaded and installed the Windows package created on the Azure build server for this PR and the first plugin synth I tried crashed Reaper.

...but it's working fine now. Weird.

Regardless, I'm closing this PR. It will be easy enough to reproduce when it's needed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rorywalsh/cabbage/pull/70#issuecomment-670983441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUQWGIFJFIFVPL4BRSKGGLR7XLLZANCNFSM4PYS3YZQ .