search

rorywalsh / wizard

1 stars 0 forks source link

Abstract classes #3

Open Robzon33 opened 4 years ago

Robzon33 commented 4 years ago

Can you have a look at my changes on my new branch https://github.com/rorywalsh/wizard/tree/addedAbstractClass? What do you think about that way to use abstract classes? Any disadvantages?

rorywalsh commented 4 years ago

Sorry @Robzon33 , I replied to the commit, but realised that's not the most accessible place to post a comment! Anyhow here is what I posted there....

Do you think we need a base player class? Ok. I guess it kind of depends on the game. For example, the game Wizard needs to keep track of each player's bid, and tricks won in a hand, where other games don't.

I wonder then should the base class simply be called 'Player' and each extension be named according to the game, like you have here, i.e, WizardPlayer? Or class GinRummyPlayer extends Player{}. Of course the naming of these derived classes will be down to the person developing the games rather than the framework we put in place..