search

ros-ai / ros2_whisper

Whisper C++ Inference Action Server for ROS 2
29 stars 9 forks source link

Batched Buffer broken #15

Open mhubii opened 4 months ago

mhubii commented 4 months ago

The BatchedBuffer can lead to

https://github.com/ros-ai/ros2_whisper/blob/d1741e656a82aa77b2f9a883fda9aa332d4aa00a/whisper_util/include/whisper_util/audio_buffers.hpp#L62

NathanCorral commented 2 months ago

Hey @mhubii,

I'm currently working on a modification to buffering and adding in a constant publisher for the audio transcript, as mentioned in issue #12.

It's still a work in progress, and you can check out my fork here.

I just wanted to avoid overlapping efforts, so I thought I'd reach out. Let me know if you'd like me to submit a pull request when it's ready.

mhubii commented 2 months ago

Hey @NathanCorral , sounds great, please do create a PR. Happy to review and merge !