Closed nlyubova closed 7 years ago
Looks like a direct copy-paste from https://github.com/ros-naoqi/pepper_robot/pull/36/files. So as long as romeo ships with the same depth sensor and the same calibration I think it's ok. Given that there are no lenses in front of romeo's depth sensor I think the near/far and fov's should be tested and updated if needed
right, it is the direct copy paste with correcting the depth frames names in the previous commit. It is completely fits with the official documentation, including HOV, ranges, etc and actually it is the same Xtion so it is not surprising :) Can I merge it?
good question, if it should fit with the doc or with the real ? The simulation is tested
Yeah I agree, I was just mentioning it in case you wanted the simulation to reflect exactly what the real robot can perceive (that may be different between romeo and pepper). But I'm totally fine with sticking with the official xtion specs for simulation if it's the desired behavior
Thank you @mikaelarguedas for your review
@mikaelarguedas do you agree?