search

ros-controls / control.ros.org

https://control.ros.org
Apache License 2.0
10 stars 36 forks source link

Add contributions to acknowledgement page #217

Closed christophfroehlich closed 5 months ago

christophfroehlich commented 5 months ago

As requested by @bmagyar ;)

I suggest using tabs for the multiple tables now. Any preferences on what showing on top?

image

Implementation detail: the tabs.js from https://github.com/executablebooks/sphinx-tabs does not work with jQuery, I added it manually here and commented the last lines. https://github.com/executablebooks/sphinx-tabs/issues/189

christophfroehlich commented 5 months ago

Btw: I just skip commits without authors, which means normally that the account doesn't exist (any more).

destogl commented 5 months ago

I suggest to add something to 12 Months tabs so one can recognize them. It could be something short like 12 Months Rev and 12 Months Contrib or even 12 Mo Reviews..., what do you think? I would start with contributions in the last 12 months.

christophfroehlich commented 5 months ago

I suggest to add something to 12 Months tabs so one can recognize them. It could be something short like 12 Months Rev and 12 Months Contrib or even 12 Mo Reviews..., what do you think? I would start with contributions in the last 12 months.

I thought about the same, but I mean it is obviously after the second click ;) But I add something and change the default tab

christophfroehlich commented 5 months ago

@destogl I updated the tabs, see the screenshot above. The only thing I'm not sure about is how well the tabs work with responsive design on mobile phones.

destogl commented 5 months ago

@destogl I updated the tabs, see the screenshot above. The only thing I'm not sure about is how well the tabs work with responsive design on mobile phones.

Looks great! Thanks! Regarding mobile phones, we don't have to optimize the page for now for it. 88% of visitors use desktop anyway.

destogl commented 5 months ago

You are welcome to merge at your convenience when check are passing. I am not sure if there is an error, or data is not available yet and will be later.

christophfroehlich commented 5 months ago

Exactly, data is not available yet. and cache from PRs can't be accessed from master workflows -> cancelled.

christophfroehlich commented 4 months ago

@mergifyio backport humble iron

mergify[bot] commented 4 months ago

backport humble iron

✅ Backports have been created

* [#218 Add contributions to acknowledgement page (backport #217)](https://github.com/ros-controls/control.ros.org/pull/218) has been created for branch `humble` but encountered conflicts * [#219 Add contributions to acknowledgement page (backport #217)](https://github.com/ros-controls/control.ros.org/pull/219) has been created for branch `iron` but encountered conflicts