Question about the ros2_controllers tab

ros-controls / control.ros.org

https://control.ros.org

Apache License 2.0

12 stars 37 forks source link

Question about the ros2_controllers tab #40

Closed joe28965 closed 1 year ago

joe28965 commented 2 years ago

So I'm talking about this page.

Some things I noticed:

Shouldn't Available Controllers be under Controllers instead of under Guidelines and Best Practices? EDIT: same for Available Broadcasters, do they fit under Guidelines and Best Practices?
The Joint Trajectory Controller link under Controllers links to a 404
With regards to the diff drive controller. Would it be a good idea if it (and the other controllers) would look more like how Nav2 does it? With a list of parameters and what they do? EDIT: or like it's done at the Joint State Controller

I wouldn't mind working on these points. I'd just like to receive input before I start.

olivier-stasse commented 2 years ago

Thanks for pointing this out. The first two points were adressed in https://github.com/ros-controls/ros2_controllers/commit/908b7cc7ed5413d3fbb09203fd5edc4fc24abdd0

The third point will need a bit more work, but I agree with the statement.

bmagyar commented 2 years ago

Does this work for point 3?

https://github.com/ros-controls/ros2_controllers/pull/371

olivier-stasse commented 2 years ago

This is definitely needed. It represents almost 2/3 of the work to be done. They are some parameters to add afterwards, such as "linear.x" and "angular.z". I can take care of it once this is merged, or do you prefer that I submit a PR on @destogl branch ?

bmagyar commented 2 years ago

Ok let me try to merge it, then you can add a new PR with your changes

On Mon, 24 Oct 2022, 10:54 Olivier Stasse, @.***> wrote:

This is definitely needed. It represents almost 2/3 of the work to be done. They are some parameters to add "linear.x" and "angular.z" afterwards. I can take care of it.

— Reply to this email directly, view it on GitHub https://github.com/ros-controls/control.ros.org/issues/40#issuecomment-1288301056, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA24PYJLEHYI6KJYZQPRRATWEXT4RANCNFSM5TJ676WA . You are receiving this because you commented.Message ID: @.***>

olivier-stasse commented 2 years ago

My bad, the parameters "linear.x" and "angular.z" are documented in https://github.com/ros-controls/ros2_controllers/commit/5c0cb9210b2230347af12bbe2690032f6942435d Once the documentation is published in control.ros.org and after a final check, then this issue is fully covered and IMHO can be closed. Thanks for the work @bmagyar !

christophfroehlich commented 1 year ago

I think that all mentioned things here are fixed already -> I close this one