ros-controls / control_toolbox

This package contains several C++ classes useful in writing controllers.
https://control.ros.org
BSD 3-Clause "New" or "Revised" License
121 stars 97 forks source link

WIP Add Parameter Handler to simplify management of params in filters and controllers and simply enable dynamic reconfigure #116

Closed destogl closed 1 year ago

destogl commented 2 years ago
bmagyar commented 2 years ago

FYI @tylerjw

destogl commented 2 years ago

Hi @tylerjw,

Thanks for the review.

My problem with this as a generic interface is it uses the ros2 interfaces directly for declaring and getting parameters. I think this would be much more useful (and future prof) if it didn't abstract away the interface for declaring (and getting) parameters.

This is a very valid comment. You are right! I was also disturbed with something, but in my “bubble” couldn't see with what.

I don't think any pattern or tool for using parameters in ROS2 should abstract away the interface in ROS2 itself and should instead just provide structure for the various steps a user needs to implement (declare, get, dynamic update) in a straightforward way.

I will think about this over the weekend and check how this can be achieved and simplified.

destogl commented 2 years ago

Note to myself:

check also this out https://github.com/ros2/rclcpp/pull/1796 (thanks @tylerjw)

destogl commented 1 year ago

This is obsolete now! Use "generate_parameters_library" repository.