search

ros-controls / control_toolbox

This package contains several C++ classes useful in writing controllers.
https://control.ros.org
BSD 3-Clause "New" or "Revised" License
120 stars 97 forks source link

[CI] Update pre-commit and remove ros-lint #187

Closed christophfroehlich closed 6 months ago

christophfroehlich commented 6 months ago

Remove ros-lint CI job but change configuration of pre-commit to run the linters with the ci-format job (renamed to ci-pre-commit) as discussed here.

Do we need the matrix strategy here, or is it sufficient to check on rolling distro?

Format fails until #188 gets merged

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.10%. Comparing base (759d954) to head (b297e2c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ros2-master #187 +/- ## ============================================ Coverage 50.10% 50.10% ============================================ Files 10 10 Lines 497 497 Branches 166 167 +1 ============================================ Hits 249 249 Misses 217 217 Partials 31 31 ``` | [Flag](https://app.codecov.io/gh/ros-controls/control_toolbox/pull/187/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros-controls/control_toolbox/pull/187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | `50.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ros-controls/control_toolbox/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [src/sine\_sweep.cpp](https://app.codecov.io/gh/ros-controls/control_toolbox/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#diff-c3JjL3NpbmVfc3dlZXAuY3Bw) | `0.00% <ø> (ø)` | |