search

ros-controls / control_toolbox

This package contains several C++ classes useful in writing controllers.
https://control.ros.org
BSD 3-Clause "New" or "Revised" License
120 stars 97 forks source link

Use Eigen CMake target #190

Closed christophfroehlich closed 6 months ago

christophfroehlich commented 6 months ago

I changed the CMake file to use Eigen's CMake target as described here https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html

This fixes #178 for RHEL 8

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.10%. Comparing base (759d954) to head (f01404c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ros2-master #190 +/- ## ============================================ Coverage 50.10% 50.10% ============================================ Files 10 10 Lines 497 497 Branches 166 166 ============================================ Hits 249 249 Misses 217 217 Partials 31 31 ``` | [Flag](https://app.codecov.io/gh/ros-controls/control_toolbox/pull/190/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros-controls/control_toolbox/pull/190/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | `50.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#carryforward-flags-in-the-pull-request-comment) to find out more.
saikishor commented 6 months ago

@christophfroehlich is this missing a test_msgs dependency?

christophfroehlich commented 6 months ago

No, rosdep fails for realtime_tools (see also https://github.com/ros-controls/realtime_tools/pull/154) [MIRROR] ros-humble-test-msgs-1.2.1-1.el8.20231117.182020.x86_64.rpm: Status code: 404 for http://packages.ros.org/ros2/rhel/8/x86_64/Packages/r/ros-humble-test-msgs-1.2.1-1.el8.20231117.182020.x86_64.rpm (IP: 140.211.166.134) I'm already debugging why, when I run it locally it installs ros-humble-test-msgs-1.2.1-1.el8.20240217.042201.x86_64 which is fine, maybe it's because metadata were updated

Last metadata expiration check: 22:01:48 ago on Fri Feb 23 00:55:05 2024.

I'm already building new docker containers, if this fixes it I'll add the missing apt update-equivalent to the rhel build.

saikishor commented 6 months ago

Awesome!

christophfroehlich commented 6 months ago

The RHEL job still needs an update https://github.com/ros-controls/ros2_control_ci/pull/19