search

ros-controls / realtime_tools

Contains a set of tools that can be used from a hard realtime thread, without breaking the realtime behavior.
https://control.ros.org
BSD 3-Clause "New" or "Revised" License
140 stars 76 forks source link

Add a helper method to lock the pages of memory in the RAM #175

Closed saikishor closed 1 month ago

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 75.36%. Comparing base (144b12c) to head (9f5af0f).

Files with missing lines Patch % Lines
src/thread_priority.cpp 0.00% 25 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #175 +/- ## ========================================== - Coverage 81.32% 75.36% -5.97% ========================================== Files 8 8 Lines 316 341 +25 Branches 54 62 +8 ========================================== Hits 257 257 - Misses 25 50 +25 Partials 34 34 ``` | [Flag](https://app.codecov.io/gh/ros-controls/realtime_tools/pull/175/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros-controls/realtime_tools/pull/175/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | `75.36% <0.00%> (-5.97%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/ros-controls/realtime_tools/pull/175?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [src/thread\_priority.cpp](https://app.codecov.io/gh/ros-controls/realtime_tools/pull/175?src=pr&el=tree&filepath=src%2Fthread_priority.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#diff-c3JjL3RocmVhZF9wcmlvcml0eS5jcHA=) | `11.42% <0.00%> (-28.58%)` | :arrow_down: |
saikishor commented 1 month ago

I'm also thinking if it makes sense to continue to thread_priority.hpp or something like realtime_helpers.hpp as it now contains the part of memory locking etc and in the future may be more. So, the header would have a meaningful name. We can add a backward compatibility with deprecation note, if we are interested to do this