ros-controls / ros2_control

Generic and simple controls framework for ROS 2
https://control.ros.org
Apache License 2.0
512 stars 304 forks source link

view_controller_chains does not work with example #1095

Open christophfroehlich opened 1 year ago

christophfroehlich commented 1 year ago

Describe the bug The output of view_controller_chains does not seem to work with the new example 12 of the demo repository.

To Reproduce Steps to reproduce the behavior:

  1. Checkout https://github.com/ros-controls/ros2_control_demos/
  2. Run the example 12 as written in the doc
  3. ros2 control view_controller_chains

Expected behavior Some chain in the PDF.

Screenshots But there are no links, just nodes: controller_diagram.gv.pdf

Environment (please complete the following information):

Additional context none

christophfroehlich commented 1 year ago

@pac48 could you please have a look on that if you find time?

pac48 commented 1 year ago

I was able to reproduce the error that you mentioned. It seems that the Python library was changed from graphviz to pygraphviz in this PR https://github.com/ros-controls/ros2_control/pull/812 When I run with the old graphviz way, I get this output.
Screenshot from 2023-08-11 15-36-46 I am not too familiar with the differences between graphviz and pygraphviz, but it seems there is a difference in usage.

Is it possible to get a diagram of what the output should look like? The output above doesn't seem right.

christophfroehlich commented 1 year ago

I haven't seen the changes from your version, sorry. Maybe @sachinkum0009 can have a look?

@saikishor designed the example, imho the graph posted above isn't correct?

bmagyar commented 1 year ago

I believe the motivation for using a different graphviz python implementation was that the former isn't supported by rosdep