search

ros-controls / ros2_control

Generic and simple controls framework for ROS 2
https://control.ros.org
Apache License 2.0
471 stars 290 forks source link

Update component parsing to cover changes to min-max #132

Closed bmagyar closed 3 years ago

bmagyar commented 4 years ago

Update the example URDFs in the component parser tests here and apply the necessary changes on the parser implementation to support them.

Related to https://github.com/ros-controls/roadmap/issues/23 https://github.com/ros-controls/roadmap/pull/25

AndyZe commented 3 years ago

Working on this

destogl commented 3 years ago

I reopen this since the issue is not settled completely (see comment)

Karsten1987 commented 3 years ago

I am btw strongly against CamelCase here and would vote for snake_case. I don't see any help in searching for "commandInterfaceType". First off, I believe the tag name is too long, but then the parser should at least allow for variants of this such as commandinterfacetype, CommandInterfaceType, commandInterfacetype, etc.

destogl commented 3 years ago

I am btw strongly against CamelCase here and would vote for snake_case.

I agree. We should update the example descriptions in the roadmap repo and then also the parser, as soon as we merge ros-controls/roadmap#27