Closed gennartan closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.64%. Comparing base (
af4b48f
) to head (e25efe8
).
Related: #1501
Related: #1501
Yes, PR #1501 seems to add the usage of timeout_sec
of spin_until_future_complete
as I did here. With two main differences:
service_timeout
variable to wait that the service is ready and to call the actual service.I don't know what would be the expected behavior from the maintainers. It is up to them to decide which behavior is prefered.
That said, I think merging one of those PR could be a priority since it is a bug in ros2_control
that can prevent a robot to start. In my case, I am starting the spawner in a launchfile and in about 30% of the cases, I must manually restart the spawner because the node didn't start correctly. Other projects in my company had the same issues.
Closing in favor of #1501 (decided on WG Meeting Aug. 14th)
In some cases, the service call might never return. As a consequence, the call to spin_until_future_complete will loop infinitely.
When the error happens:
[controller_manager.rclcpp]: failed to send response to /controller_manager/list_controllers (timeout): client will not receive response, at ./src/rmw_response.cpp:154, at ./src/rcl/service.c:402
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)