Open saikishor opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.50%. Comparing base (
723c869
) to head (2540431
).
Great addition 👍
Why not just use
update_rate
as attribute name (same as forcontroller_manager
or the controllers)Please update the docs and add also a paragraph to the release notes.
Sure. I forgot about the docs. I'll update it tomorrow at the earliest. Thanks for reminding me.
Well regarding the parameter name, I thought of using different because, we have update_rate
for the update callback of the controllers and for the hardware I wanted to use the appropriate one, so I used rw_rate
to specify the read/write_rate
. How the changes are done, in future we can also have different read and write rates if needed, with just changing the parsing part. I'm open to the discussion on the parameter naming part.
This pull request is in conflict. Could you fix it @saikishor?
Resolved conflicts!
This pull request is in conflict. Could you fix it @saikishor?
@christophfroehlich I've just fixed the conflicts after your merged PR on deprecating mimic stuff
Hello!
This PR helps to obtain different read and write update rates rather than having the same update rate as of the controller manager. With these changes, each and every component can run at their own chosen rate and they update the State and Command interfaces according to that rate. This is very useful for system with different communication layers such as EtherCAT, CAN and Serial. Hope this helps the community.
Thank you