search

ros-controls / ros2_control

Generic and simple controls framework for ROS 2
https://control.ros.org
Apache License 2.0
433 stars 272 forks source link

Small improvements to the error output in component parser to make debugging easier. (backport #1580) #1582

Open mergify[bot] opened 2 weeks ago

mergify[bot] commented 2 weeks ago

This is an automatic backport of pull request #1580 done by Mergify.

mergify[bot] commented 2 weeks ago

Cherry-pick of fbb893bdaa645216c1e11d0d6e2cf3dd60f5939d has failed:

On branch mergify/bp/iron/pr-1580
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit fbb893b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   hardware_interface/src/component_parser.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (ae2ed7c) to head (633ba0e). Report is 3 commits behind head on iron.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## iron #1582 +/- ## ========================================== - Coverage 87.45% 87.45% -0.01% ========================================== Files 101 101 Lines 8078 8080 +2 Branches 711 711 ========================================== + Hits 7065 7066 +1 - Misses 717 718 +1 Partials 296 296 ``` | [Flag](https://app.codecov.io/gh/ros-controls/ros2_control/pull/1582/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros-controls/ros2_control/pull/1582/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | `87.45% <50.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ros-controls/ros2_control/pull/1582?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [hardware\_interface/src/component\_parser.cpp](https://app.codecov.io/gh/ros-controls/ros2_control/pull/1582?src=pr&el=tree&filepath=hardware_interface%2Fsrc%2Fcomponent_parser.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#diff-aGFyZHdhcmVfaW50ZXJmYWNlL3NyYy9jb21wb25lbnRfcGFyc2VyLmNwcA==) | `93.69% <50.00%> (-0.40%)` | :arrow_down: |