ros-controls / ros2_control

Generic and simple controls framework for ROS 2
https://control.ros.org
Apache License 2.0
478 stars 293 forks source link

Test `unload_on_kill_activate_as_group` fails on jazzy/testing #1753

Open christophfroehlich opened 2 weeks ago

christophfroehlich commented 2 weeks ago
2024-09-13T02:29:16.7694364Z 9: /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/controller_manager/test/test_spawner_unspawner.cpp:347: Failure
2024-09-13T02:29:16.7694540Z 9: Expected equality of these values:
2024-09-13T02:29:16.7694700Z 9:   cm_->get_loaded_controllers().size()
2024-09-13T02:29:16.7694790Z 9:     Which is: 2
2024-09-13T02:29:16.7694871Z 9:   0ul
2024-09-13T02:29:16.7694961Z 9:     Which is: 0
2024-09-13T02:29:16.7704118Z 9: 

see https://github.com/ros-controls/ros2_control/issues/1751 and https://github.com/ros-controls/ros2_control/actions/runs/10841825910/attempts/1

christophfroehlich commented 2 weeks ago

@saikishor could you have a look maybe?

saikishor commented 2 weeks ago

@christophfroehlich Is it failing more frequently?

saikishor commented 2 weeks ago
     [INFO] [1726194509.916911268] [spawner_ctrl_3]: [NON-XML-CHAR-0x1B][92mConfigured and activated all the parsed controllers list : ['ctrl_3', 'ctrl_2']![NON-XML-CHAR-0x1B][0m
    [INFO] [1726194509.917833389] [spawner_ctrl_3]: Waiting until interrupt to unload controllers
    /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/controller_manager/test/test_spawner_unspawner.cpp:347: Failure
    Expected equality of these values:
      cm_->get_loaded_controllers().size()
        Which is: 2
      0ul
        Which is: 0

Seems like it didn't catch the keyboard interrupt. Let's wait to see if this happens more often.

Thank you!

christophfroehlich commented 2 weeks ago

Now and then, but at the next try it succeeded

saikishor commented 2 weeks ago

Now and then, but at the next try it succeeded

Gotcha! We should keep an eye on this.