ros-controls / ros2_control

Generic and simple controls framework for ROS 2
https://control.ros.org
Apache License 2.0
516 stars 306 forks source link

First Foxy release #74

Closed bmagyar closed 3 years ago

bmagyar commented 4 years ago

List of required features from ros2_control and ros2_controllers for the first Foxy release:

Waiting for contributions to this list @jordan-palacios @Karsten1987 @piraka9011

bmagyar commented 4 years ago

My first list is what I think of as bare minimum.

I'd opt for shipping something now to have some functionality available but with ideally it'd be good to be able to ship some framework improvements (aka all the stuff in design docs) to Foxy too, meaning they may be slightly breaking changes, at least within the scope of framework components which we'd manage. The yearly release proposed starting from Foxy doesn't leave us with very good alternatives if we want to ship stuff in a timely manner. What are your thoughts on this guys? @Karsten1987 @jordan-palacios @piraka9011

piraka9011 commented 4 years ago

SGTM, not sure how large of a change gazebo_ros_control would be but maybe focusing on framework/infra stuff might be better?

destogl commented 4 years ago

@bmagyar, what is the best way to manage the roadmap for this? I mean the list of tasks with technical / implementation steps. We need to coordinate ourselves somehow...

Should we just open one issue, with a checklist of tasks and responsible person for it? Or ist it better to use GitHub-Project option? Has anyone experience with that? If we go the latter path, then I would need access rights to this repository.

bmagyar commented 4 years ago

How about a new section in the roadmap repo for a general outline? I can look into how we could leverage github project for the execution

piraka9011 commented 4 years ago

@bmagyar @destogl We have a zenhub board setup in the roadmap repo. It does require an extension though. A GitHub project board also works.

ruffsl commented 4 years ago

A GitHub project board also works.

+1 for project visibility and being co-located with the repo. I was checking up on gazebo_ros_control, which led me here, wondering about the state of ros2_control, and where the project roadmap was.

destogl commented 4 years ago

@ruffsl you can find it in the roadmap repository

destogl commented 4 years ago

The PRs for the release:

ros2_control:

ros2_controllers:

ros2_control_demos

Demo Robots (at least one)

gavanderhoorn commented 4 years ago

Demo Robots (at least one)

* ABB Studio
* ABB Robot
* KUKA Robot

I haven't been able to attend the meetings, so this could have been discussed there.

Could you provide some more info on availability of interfaces for the two robot OEMs you mention?

destogl commented 4 years ago

There are currently none, but people said they can provide them. I can notify you when we start to work on it.

I am not experienced with ABB. For KUKA we will be porting RSI-Driver from kuka_experimental.

bmagyar commented 3 years ago

I've added doc and source jobs to Foxy for ros2_control https://github.com/ros/rosdistro/pull/27622 This should give us some ROS2 buildfarm feedback

destogl commented 3 years ago

How should we provide doc? Or how do we want to provide it? also in the long-term.

bmagyar commented 3 years ago

I'd like to contribute those to the main ROS2 docs page if possible, we could create a sub-section there or we could even ask for a subdomain like https://navigation.ros.org/

destogl commented 3 years ago

It would be great if we could have something directly in the repositories. So that each package has doc folder. I believe this would be the easiest to maintain and keep track of changes. What do you think?

bmagyar commented 3 years ago

I was actually thinking about this last night and had a similar idea that we should try to keep them local but since it'd also be beneficial to have this appear in a central place, we could use a script that collates the individual package docs and periodically we sync them up.

destogl commented 3 years ago

How other people are doing this? I saw the recommendation that doc could be in the code repository. Is buildfarm maybe doing this automatically?

bmagyar commented 3 years ago

Had two other PRs open during the holidays but nobody merged. Was asked to use a different release repo, these should be the most up to date PRs that will make it to Foxy.

https://github.com/ros/rosdistro/pull/27872 https://github.com/ros/rosdistro/pull/27873

bmagyar commented 3 years ago

https://discourse.ros.org/t/announcing-ros2-control-for-foxy/18274