I would like to merge the API change of adding time and period (#846) on both methods in chainable controllers into humble to, to make the transition simpler and more graceful. Nevertheless, we have to make an ABI change for it. The impact should be little since no many people are using chainable controllers (since there is also no clear documentation about it – shame on me…)
The idea would be the following:
Add new method with parameters as virtual.
Make default implementation that calls the method without parameters and notifies user about its deprecation.
When user overrides the new method, there is also no deprecation notice anymore.
I would like to merge the API change of adding time and period (#846) on both methods in chainable controllers into humble to, to make the transition simpler and more graceful. Nevertheless, we have to make an ABI change for it. The impact should be little since no many people are using chainable controllers (since there is also no clear documentation about it – shame on me…)
The idea would be the following:
What do you think?