search

ros-controls / ros2_control_ci

This repository holds reusable workflows for CI of the ros2_control framework.
https://control.ros.org
Apache License 2.0
2 stars 1 forks source link

ICI: Remove caching of workspace #49

Closed christophfroehlich closed 3 months ago

christophfroehlich commented 3 months ago

Fixes #33 the easiest way: just don't cache the workspace, but only ccache directory.

Does it make sense to cache the workspace at all, how much is the speed benefit compared to only caching ccache?

  • Locally, it takes 20s vs 2min if I remove the build folder.
  • cache vs no cache of ros2_control binary build: The ICI step takes the same time.

This also resolved some weird include errors while updating an upstream dependency in https://github.com/ros-controls/ros2_control/pull/1485 (yes, we could delete the caches manually but still..)

fmauch commented 3 months ago

Wait - if we remove the target_ws cache we do not increase build time? Then I really think this is worth going that route.

christophfroehlich commented 3 months ago

Wait - if we remove the target_ws cache we do not increase build time? Then I really think this is worth going that route.

Please verify that once again :smile: but the two workflow runs I've linked above don't show any difference.

christophfroehlich commented 3 months ago

Also for semi-binary builds, the build-step of ICI takes approx 30s only with/without cache (the upstream workspace was not cached anyways).