search

ros-controls / ros2_control_ci

This repository holds reusable workflows for CI of the ros2_control framework.
https://control.ros.org
Apache License 2.0
2 stars 1 forks source link

Use official ros images for pre-commit #69

Closed christophfroehlich closed 2 months ago

christophfroehlich commented 2 months ago

As ros:jazzy is available, we can use it and install ros only optionally -> way faster

Calling workflows do not fail if inputs are set which aren't available (no need to change every usage of reusable-pre-commit now).

christophfroehlich commented 2 months ago

This looks good to me, but I am wondering whether it would make sense to use that for the coverage build as well?

I thought the same, I'll change that

christophfroehlich commented 2 months ago

Calling workflows do not fail if inputs are set which aren't available (no need to change every usage of reusable-pre-commit now).

Oops. they do:

Invalid workflow file: .github/workflows/ci-pre-commit.yml#L30 The workflow is not valid. .github/workflows/ci-pre-commit.yml (Line: 30, Col: 16): Invalid input, os_name is not defined in the referenced workflow. .github/workflows/ci-pre-commit.yml (Line: 31, Col: 18): Invalid input, container is not defined in the referenced workflow.