search

ros-controls / ros2_control_demos

This repository aims at providing examples to illustrate ros2_control and ros2_controllers
https://control.ros.org
Apache License 2.0
384 stars 182 forks source link

Update all demos using the description from topic rather than the parameter #456

Closed fmauch closed 5 months ago

fmauch commented 6 months ago

This will make sure things work after https://github.com/ros-controls/ros2_control/pull/1358 is merged.

I'll update this demo by demo whenever I find the time and check the demos according to their docs after modifying them.

fmauch commented 5 months ago

Migrated all demos and manually tested them.

fmauch commented 5 months ago

The changes look good to me!

Let's merge once ros-controls/ros2_control#1358 is merged!

I don't see any specific reason to wait for that, as this PR removes long-deprecated mechanisms and is in line with the docs again, but sure, it's not necessarily required before https://github.com/ros-controls/ros2_control/pull/1358 is merged.

saikishor commented 5 months ago

Sure, we can merge it. You have a point 👍🏽

Let's wait for one more approval for merging it :)

fmauch commented 5 months ago

No, this will not work on humble because we subscribe to robot_description and not ~/robot_description on rolling.

christophfroehlich commented 5 months ago

No, this will not work on humble because we subscribe to robot_description and not ~/robot_description on rolling.

ah you are right. should we backport the rest?