search

ros-controls / ros2_control_demos

This repository aims at providing examples to illustrate ros2_control and ros2_controllers
https://control.ros.org
Apache License 2.0
412 stars 187 forks source link

Update publishing rate for example_2 in userdoc.rst #573

Closed Pratham-Pandey closed 2 months ago

Pratham-Pandey commented 2 months ago

Updated publishing rate to match with diff_drive controller update rate (as in 3rd line of config file).

christophfroehlich commented 2 months ago

This would not be necessary actually, the controller just uses the old command until it gets a new one :man_shrugging:

christophfroehlich commented 2 months ago

@mergifyio backport iron humble

mergify[bot] commented 2 months ago

backport iron humble

✅ Backports have been created

* [#574 Update publishing rate for example_2 in userdoc.rst (backport #573)](https://github.com/ros-controls/ros2_control_demos/pull/574) has been created for branch `iron` * [#575 Update publishing rate for example_2 in userdoc.rst (backport #573)](https://github.com/ros-controls/ros2_control_demos/pull/575) has been created for branch `humble`
Pratham-Pandey commented 2 months ago

This would not be necessary actually, the controller just uses the old command until it gets a new one 🤷‍♂️

Would not this create unnecessary load(although negligible) on the system as publishing more frequently would use more resource?

christophfroehlich commented 2 months ago

Sorry, forget my comment. I was wrong and thought you increased the update rate. Reducing it is totally fine, there is no reason for sending this faster here.