search

ros-controls / ros2_controllers

Generic robotic controllers to accompany ros2_control
https://control.ros.org
Apache License 2.0
321 stars 290 forks source link

steering_controllers: Fix deprecation warning #1155

Closed christophfroehlich closed 1 month ago

christophfroehlich commented 1 month ago

I made a mistake with #1093: The deprecation warning was inserted in the wrong place. Will be removed with #1151 on rolling, but let's fix this on iron.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.79%. Comparing base (ced16a8) to head (1326505).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## iron #1155 +/- ## ========================================== + Coverage 86.69% 86.79% +0.09% ========================================== Files 86 86 Lines 7411 7413 +2 Branches 612 613 +1 ========================================== + Hits 6425 6434 +9 + Misses 758 750 -8 - Partials 228 229 +1 ``` | [Flag](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1155/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1155/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | `86.79% <0.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1155?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [...llers\_library/src/steering\_controllers\_library.cpp](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1155?src=pr&el=tree&filepath=steering_controllers_library%2Fsrc%2Fsteering_controllers_library.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#diff-c3RlZXJpbmdfY29udHJvbGxlcnNfbGlicmFyeS9zcmMvc3RlZXJpbmdfY29udHJvbGxlcnNfbGlicmFyeS5jcHA=) | `74.16% <0.00%> (-0.32%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1155/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls)