Open mergify[bot] opened 1 month ago
Needs https://github.com/ros-controls/control_msgs/pull/133 to be released for the binary builds.
Attention: Patch coverage is 84.28875%
with 74 lines
in your changes missing coverage. Please review.
Project coverage is 86.48%. Comparing base (
deeb9d0
) to head (5eb6df8
).
Needs ros-controls/control_msgs#133 to be released for the binary builds.
@christophfroehlich, That has been merged, right? Can the build check just be re-triggered?
Needs ros-controls/control_msgs#133 to be released for the binary builds.
@christophfroehlich, That has been merged, right? Can the build check just be re-triggered?
The binary build check fails until control_msgs has been released (there is a release, waiting for the next sync). I think this PR can be merged now, too @bmagyar ?
Proposal for a new controller that provides PID functionality.
The controller can be used stand-alone, in a chain. Measured states can be provided through the topic or state interface, depening on the concrete control arch. For example, if you are having an external estimator, using topic might be eaiser at first then full integration into ros2_control.
The PR depends the following changes:
Looking forward for your feedback!
Testing dependencies:
This is an automatic backport of pull request #434 done by Mergify.