search

ros-controls / ros2_controllers

Generic robotic controllers to accompany ros2_control
https://control.ros.org
Apache License 2.0
355 stars 319 forks source link

[STEERING] Add missing `tan` call for ackermann (backport #1117) #1177

Closed mergify[bot] closed 3 months ago

mergify[bot] commented 3 months ago

The steering library is missing a call to calculate tangent from steering pos at ackermann code.

This is an automatic backport of pull request #1117 done by Mergify.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.42%. Comparing base (014848c) to head (54f9ba1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## iron #1177 +/- ## ========================================== - Coverage 86.76% 86.42% -0.34% ========================================== Files 91 91 Lines 7873 7875 +2 Branches 688 690 +2 ========================================== - Hits 6831 6806 -25 - Misses 795 819 +24 - Partials 247 250 +3 ``` | [Flag](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | `86.42% <100.00%> (-0.34%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1177?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls) | Coverage Δ | | |---|---|---| | [...ring\_controllers\_library/src/steering\_odometry.cpp](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1177?src=pr&el=tree&filepath=steering_controllers_library%2Fsrc%2Fsteering_odometry.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls#diff-c3RlZXJpbmdfY29udHJvbGxlcnNfbGlicmFyeS9zcmMvc3RlZXJpbmdfb2RvbWV0cnkuY3Bw) | `73.79% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/ros-controls/ros2_controllers/pull/1177/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-controls)