mergify[bot]
commented
4 days ago Cherry-pick of 07061f96f21fd4436a1f48b29e74beb21be8709a has failed:
On branch mergify/bp/humble/pr-716
Your branch is up to date with 'origin/humble'.
You are currently cherry-picking commit 07061f9.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: joint_trajectory_controller/CMakeLists.txt
modified: joint_trajectory_controller/doc/userdoc.rst
modified: joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
modified: joint_trajectory_controller/include/joint_trajectory_controller/tolerances.hpp
modified: joint_trajectory_controller/src/joint_trajectory_controller.cpp
new file: joint_trajectory_controller/test/test_tolerances.cpp
modified: joint_trajectory_controller/test/test_trajectory_actions.cpp
modified: joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
Unmerged paths:
(use "git add/rm <file>..." as appropriate to mark resolution)
deleted by us: doc/migration/Jazzy.rst
deleted by us: doc/release_notes/Jazzy.rst
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
codecov[bot]
From here:
This PR proposes a way how to process the tolerances: The tolerances from one action goal are not saved for the next one, but the default ones will be used if no tolerances are set with the following action goals.
(Temporary) deactivation is also implemented like documented in the msg definition.
From the node parameter we cannot set velocity or acceleration tolerances (except for a single
stopped_velocity_tolerancefor the goal tolerances of all joints). Should we add them as parameters as well, to have the same structure like the action message?This new feature could break some existing projects, because the tolerances were just ignored and might now be breaking behaviors. Should we introduce a temporary parameter to opt-in?
Fixes #249
This is an automatic backport of pull request #716 done by Mergify.