search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
470 stars 307 forks source link

fixed startup bug #426

Closed ThibaultRouillard closed 4 years ago

ThibaultRouillard commented 4 years ago

There was a #KeyError: 'initialized

Adding the return in a try: fixes it.

wxmerkt commented 4 years ago

This is currently broken in Melodic from binaries so it would be great to get a fix in ASAP :-).

bmagyar commented 4 years ago

@ThibaultRouillard @wxmerkt I've cleaned up the PR and it is now ready for merge. As we don't have CI specifically for rqt plugins I have to ask you guys for confirmation that this fixes the issue you are seeing. As soon as this is in I'm ready to push the next melodic release.

wxmerkt commented 4 years ago

Thank you for the swift action :-) I can confirm this fixes the issue

ThibaultRouillard commented 4 years ago

Sorry for the delay. Thank you for accepting the request.

bmagyar commented 4 years ago

https://github.com/ros/rosdistro/pull/23860