[trivial but useful] Allow spawner to wait indefinitely if requested

ros-controls / ros_control

Generic and simple controls framework for ROS

http://wiki.ros.org/ros_control

BSD 3-Clause "New" or "Revised" License

470 stars 307 forks source link

[trivial but useful] Allow spawner to wait indefinitely if requested #428

Closed v4hn closed 4 years ago

v4hn commented 4 years ago

rospy.wait_for_service does not allow for 0 to wait indefinitely. Instead None has to be passed explicitly.

A user-provided value of 0 leads to an error message and failure at the moment, so it is alright to use the value to indicate indefinite waiting time.

destogl commented 4 years ago

+1 for --no-timeout

bmagyar commented 4 years ago

I see value in both using the number to encode wait time (if passed in through a parameter) and the more verbose option. Can we have both please? ;)

v4hn commented 4 years ago

Wow, it is a trivial patch obviously improving applicability in a case that was not documented at all before. I barely care whether it gets merged or not, I just took a minute to pull-request what I typed locally.

So I'm a bit surprised to get further request for icing and sprinkles. sigh Anyway addressed.

bmagyar commented 4 years ago

@v4hn indeed sometimes it is unusual to be on the receiving end of reviews ;)