search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
470 stars 307 forks source link

Use setuptools instead of distutils #429

Closed matthew-reynolds closed 4 years ago

matthew-reynolds commented 4 years ago

Use setuptools rather than distutils. See http://wiki.ros.org/noetic/Migration and ros/catkin#1048.

This PR also removes shebangs from setup.py files, since they should not be executed directly.

Note that it is not necessary to update all package.xml versions to 3, it is only required for packages containing setup.py files. But I updated them all for consistency.

matthew-reynolds commented 4 years ago

hmm... Not sure why these egg-infos are being generated. Looking into it.

bmagyar commented 4 years ago

Is this something that we could also leverage in melodic?

matthew-reynolds commented 4 years ago

Yeah, in fact it should be cherry picked back to Kinetic as well, once the issues are resolved. https://github.com/ros/catkin/pull/1048 updated the recommended tool from Kinetic onwards.

Regarding the egg-info issue, this is being tracked upstream at https://github.com/ros/catkin/issues/1069.

ahcorde commented 4 years ago

Hi @matthew-reynolds and @bmagyar any updates here? These changes are need it for release the package in Noetic

matthew-reynolds commented 4 years ago

any updates here?

Waiting on the upstream issue ros/catkin#1069. I just submitted a PR to address this (ros/catkin#1073), but I am not very well versed in the catkin codebase so I expect some discussion and iteration before that's resolved.

matthew-reynolds commented 4 years ago

Upstream PR merged into noetic-devel (ros/catkin#1073), just waiting on a backport to kinetic-devel now.

matthew-reynolds commented 4 years ago

Upstream backport is done. Waiting on next catkin release (https://github.com/ros/rosdistro/pull/24386). Once that is done, we can re-run this PR's tests, but only half of our tests will pass (the ros-testing ones) until the next Melodic sync.

bmagyar commented 4 years ago

Rebased to noetic and ready to merge when CI is happy