search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
470 stars 307 forks source link

Fixed compile tests #434

Closed ahcorde closed 4 years ago

ahcorde commented 4 years ago

Tests are not able to find resource_retriever/retriever.h headers

Signed-off-by: ahcorde ahcorde@gmail.com

ahcorde commented 4 years ago

thank your for the review @matthew-reynolds

bmagyar commented 4 years ago

How did this issue not show up on our CI?

matthew-reynolds commented 4 years ago

How did this issue not show up on our CI?

Probably because ${catkin_INCLUDE_DIRS} always contains /opt/ros/melodic/include.

(Maybe you could come up with some minimal, contrived, barely-even-ROS example that doesn't include that dir, but in all practical cases, it's always included.)