search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
470 stars 307 forks source link

Update travis config and rosinstall for noetic #439

Closed bmagyar closed 4 years ago

bmagyar commented 4 years ago

@ipa-mdl @matthew-reynolds I had to juggle a bunch to get this to pass. The Python2-Python3 switch broke string comparisons in one of the tests I had to chase and it also seems that rostests run from install space which means we have to install most of the test-related stuff.

bmagyar commented 4 years ago

I'll go ahead with the merge as thsi is now blocking a bunch of other PR-s. Happy to accomodate any changes post-merge

mikaelarguedas commented 3 years ago

This PR seems to have broken deb install on Noetic as now the package installs gtest in a common location that is conflicting with other ROS packages doing the same:

Unpacking ros-noetic-controller-manager-tests (0.19.4-1focal.20201207.152344) ...
dpkg: error processing archive /tmp/apt-dpkg-install-2E6ylt/1076-ros-noetic-controller-manager-tests_0.19.4-1focal.20201207.152344_amd64.deb (--unpack):
 trying to overwrite '/opt/ros/noetic/lib/python3/dist-packages/libgtest.so', which is also in package ros-noetic-tf 1.13.2-1focal.20210112.083534
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)

(I just tried to install ros-noetic-* and am not relying of the deb of this package)

matthew-reynolds commented 3 years ago

@mikaelarguedas I think this is resolved by https://github.com/ros/catkin/pull/1135 which has finally been merged. Let me know if not and I'll look into if we're doing anything weird here, but I think our CMakeLists are pretty standard.

mikaelarguedas commented 3 years ago

That makes sense, thanks for the pointer 👍