search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
470 stars 307 forks source link

Spawning stopped controllers sets them to state `initialized` instead of `stopped` #451

Closed Martin-Oehler closed 4 years ago

Martin-Oehler commented 4 years ago

Hello everyone,

I tried to spawn controllers stopped with

rosrun controller_manager spawner --stopped flipper_front_velocity_controller

However, this puts the controller from state uninitialized to initialized instead of the expected state stopped. Did this behavior change somehow?

This leads to the problem, that you are no longer able to start a controller using the rqt_controller_manager plugin, which does not offer a right-click menu for items in the initialized state.

Is this the expected behavior? Thanks for your help.

Edit: I am using the Melodic release.

Best regards, Martin

RobertWilbrandt commented 4 years ago

The behavior was changed in this PR, which added additional states. I also found the rqt problem (see #445), it should be fixed since #450. Could you try using the current rqt_controller_manager version (i.e. from source) and check if this works for you?

Martin-Oehler commented 4 years ago

Yes, this did indeed work. Thank you for the fast response.

bmagyar commented 4 years ago

Thanks guys for both reporting & providing the fix. I've made the release for Melodic: https://github.com/ros/rosdistro/pull/24803

Should get around with a new release with Noetic containing this fix too today