search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
470 stars 307 forks source link

Make handling of registered InterfaceManagers in InterfaceManager transparent #456

Closed RobertWilbrandt closed 3 years ago

RobertWilbrandt commented 4 years ago

This fixes #452. Most importantly, it handles registered InterfaceManagers transparently inside the getNames() and getInterfaceResources() functions (adding interfaces and resources from them and removing duplicates when needed). In addition, a test for this functionality is added and the documentation is updated (most of it didn't get updated since when registerInterfaceManager()was introduced). Finally, a small duplicate error message was removed.

RobertWilbrandt commented 3 years ago

Thanks for looking through this. I tried applying all requested changes, and since there was some time since the initial pr i went ahead and rebased to current melodic_devel.

RobertWilbrandt commented 3 years ago

I applied the documentation changes. Regarding the formatting: Are there any guidelines for this? I tried keeping line-lengths etc consistent for the touched files, but other files are formatted completely different. Is there any preferred clang-format config (e.g. moveit)?

bmagyar commented 3 years ago

It actually looks all good to me I was just hoping for a little more feedback from others. Let's go ahead with this though, I'll cherry-pick it to Noetic as well and push some releases