search

ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
478 stars 306 forks source link

Remove ParseStatus enum #470

Closed jlack1987 closed 4 years ago

jlack1987 commented 4 years ago

This is to fix https://github.com/ros-controls/ros_control/issues/333. I ultimately removed the ParseStatus enum. It didn't appear there being 3 valid return types was adding value so I thought removing it made the most sense. Let me know what you think

bmagyar commented 4 years ago

@ipa-mdl or @matthew-reynolds for a second look?

jlack1987 commented 4 years ago

@bmagyar unless there are further reviewer comments incoming I think this one is ready to go

bmagyar commented 4 years ago

It is indeed, thanks for the contribution!