Fix Windows compilation

ros-controls / ros_control

Generic and simple controls framework for ROS

http://wiki.ros.org/ros_control

BSD 3-Clause "New" or "Revised" License

469 stars 307 forks source link

Fix Windows compilation #492

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 3 years ago

ERROR needs to be undefined on Windows, otherwise compilation fails.

traversaro commented 3 years ago

Related PR from the past: https://github.com/ros-controls/ros_control/pull/397 . Also https://github.com/ros-industrial/abb_robot_driver/issues/17 seems related.

bmagyar commented 3 years ago

Adding preprocessor hacks to downstream packages to avoid ancient macros spilling into their code will never look good.

I'd really prefer if this could be worked around without littering in the ros_control codebase. The -DNOGDI solution worked before, is that something that could be employed in this case too perhaps? Let's keep the discussion on https://github.com/ros-industrial/abb_robot_driver/issues/17