ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
469 stars 307 forks source link

Add controller stopper node #512

Open fmauch opened 1 year ago

fmauch commented 1 year ago

This basically implements #510.

The controller stopper basically listens to a boolean topic and stops all controllers instead of a set of preconfigured controllers when receiving a false message. On a true message it restarts the previously stopped controllers. This has the following benefits:

Obviously, this is a rather simple method to achieve that goal which has the culprit that nothing stops users from starting controllers manually while robot control is not active...

fmauch commented 1 year ago

The failing tests seem not to be related. @bmagyar Do you think it would be worth it writing a test for the controller stopper? I guess the answer would be "with test coverage every PR is nicer".