ros-controls / ros_control

Generic and simple controls framework for ROS
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
487 stars 307 forks source link

QTimer::setInterval expects int argument #519

Closed rhaschke closed 1 month ago

rhaschke commented 1 year ago

Since Ubuntu 22.04 / Qt 5.15, Qt seems to be pickier about the correct type, and loading the rqt plugin fails. https://doc.qt.io/qt-5/qtimer.html#interval-prop

bmagyar commented 1 year ago

Seems pretty harmless for Noetic still... Am I correct?

rhaschke commented 1 year ago

Hi Bence, this aims for ROS One / Obese (running on Ubuntu 22.04). But it shouldn't harm on Noetic either.

rhaschke commented 1 year ago

I don't think the test failure is linked to my change.

bmagyar commented 1 year ago

agreed, I'll re-run them, I think it's only flakiness