search

ros-controls / ros_controllers

Generic robotic controllers to accompany ros_control
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
560 stars 526 forks source link

JointPositionController and friends unit tests #266

Open bmagyar opened 7 years ago

bmagyar commented 7 years ago

Reviewing #245 revealed that there are no unit tests for effort_controllers/XYController. See here. These controllers are mostly wrappers around the PID class but basic integration-level functionalities such as params and namespaces (just added) should still be tested.

@progtologist has kindly volunteered to add some of these.

bmagyar commented 7 years ago

ping @progtologist

progtologist commented 7 years ago

@bmagyar I will look into it in a few days, sorry but I have been extremely busy this past month!

bmagyar commented 7 years ago

ping